[NewRelic] SDK validation for TypeSpec swagger by mzhongl524 · Pull Request #53254 · Azure/azure-sdk-for-net

mzhongl524 · 2025-10-15T09:33:16Z

This is the SDK validation for NewRelic.
TSP link: Azure/azure-rest-api-specs#36442.

Changes:

Add renaming and directive in the autorest file
Add custom code

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

github-actions · 2025-10-16T01:33:59Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.NewRelicObservability

Copilot

Pull Request Overview

This PR updates the Azure NewRelic Observability SDK to use the latest TypeSpec swagger specification, upgrading from package version 2024-03-01 to 2025-05-01-preview.

Updates autorest configuration file with new API version and model mappings
Adds custom model factory methods for backward compatibility
Updates API surfaces to reflect changes in type specifications
Includes a directive to handle MonitoredSubscription model generation

Reviewed Changes

Copilot reviewed 6 out of 103 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Azure.ResourceManager.NewRelicObservability.Tests.csproj	Adds placeholder folder for generated samples
autorest.md	Updates API version, adds model mappings, enables debug mode, and includes directive for MonitoredSubscription
ArmNewRelicObservabilityModelFactory.cs	Adds custom model factory methods for backward compatibility
API surface files (.netstandard2.0/.net8.0)	Updates type signatures from string to typed identifiers and renames ResubscribeProperties
CHANGELOG.md	Documents API version update

Copilot · 2025-10-16T03:27:41Z

+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public static NewRelicMonitorResourceData NewRelicMonitorResourceData(ResourceIdentifier id, string name, ResourceType resourceType, SystemData systemData, IDictionary<string, string> tags, AzureLocation location, ManagedServiceIdentity identity = null, NewRelicProvisioningState? provisioningState = null, NewRelicObservabilityMonitoringStatus? monitoringStatus = null, NewRelicObservabilityMarketplaceSubscriptionStatus? marketplaceSubscriptionStatus = null, string marketplaceSubscriptionId = null, NewRelicAccountProperties newRelicAccountProperties = null, NewRelicObservabilityUserInfo userInfo = null, NewRelicPlanDetails planData = null, NewRelicLiftrResourceCategory? liftrResourceCategory = null, int? liftrResourcePreference = null, NewRelicObservabilityOrgCreationSource? orgCreationSource = null, NewRelicObservabilityAccountCreationSource? accountCreationSource = null, string subscriptionState = null, string saaSAzureSubscriptionStatus = null)
+        {
+            return NewRelicMonitorResourceData(id, name, resourceType, systemData, tags, location, identity, provisioningState, monitoringStatus, marketplaceSubscriptionStatus, marketplaceSubscriptionId, newRelicAccountProperties, userInfo, planData, saaSResourceId: default, liftrResourceCategory, liftrResourcePreference, orgCreationSource, accountCreationSource);


[nitpick] The method call is extremely long with many parameters. Consider breaking this into multiple lines with proper parameter alignment for better readability.

Suggested change

return NewRelicMonitorResourceData(id, name, resourceType, systemData, tags, location, identity, provisioningState, monitoringStatus, marketplaceSubscriptionStatus, marketplaceSubscriptionId, newRelicAccountProperties, userInfo, planData, saaSResourceId: default, liftrResourceCategory, liftrResourcePreference, orgCreationSource, accountCreationSource);

return NewRelicMonitorResourceData(

id,

name,

resourceType,

systemData,

tags,

location,

identity,

provisioningState,

monitoringStatus,

marketplaceSubscriptionStatus,

marketplaceSubscriptionId,

newRelicAccountProperties,

userInfo,

planData,

saaSResourceId: default,

liftrResourceCategory,

liftrResourcePreference,

orgCreationSource,

accountCreationSource

);

Copilot · 2025-10-16T03:27:41Z

+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public static NewRelicMonitorResourceData NewRelicMonitorResourceData(ResourceIdentifier id, string name, ResourceType resourceType, SystemData systemData, IDictionary<string, string> tags, AzureLocation location, ManagedServiceIdentity identity, NewRelicProvisioningState? provisioningState, NewRelicObservabilityMonitoringStatus? monitoringStatus, NewRelicObservabilityMarketplaceSubscriptionStatus? marketplaceSubscriptionStatus, string marketplaceSubscriptionId, NewRelicAccountProperties newRelicAccountProperties, NewRelicObservabilityUserInfo userInfo, NewRelicPlanDetails planData, NewRelicLiftrResourceCategory? liftrResourceCategory, int? liftrResourcePreference, NewRelicObservabilityOrgCreationSource? orgCreationSource, NewRelicObservabilityAccountCreationSource? accountCreationSource)
+        {
+            return NewRelicMonitorResourceData(id: id, name: name, resourceType: resourceType, systemData: systemData, tags: tags, location: location, identity: identity, provisioningState: provisioningState, monitoringStatus: monitoringStatus, marketplaceSubscriptionStatus: marketplaceSubscriptionStatus, marketplaceSubscriptionId: marketplaceSubscriptionId, newRelicAccountProperties: newRelicAccountProperties, userInfo: userInfo, planData: planData, liftrResourceCategory: liftrResourceCategory, liftrResourcePreference: liftrResourcePreference, orgCreationSource: orgCreationSource, accountCreationSource: accountCreationSource, subscriptionState: default, saaSAzureSubscriptionStatus: default);


[nitpick] This method call spans an extremely long single line with numerous parameters. Break this into multiple lines with proper indentation for better code readability and maintainability.

Suggested change

return NewRelicMonitorResourceData(id: id, name: name, resourceType: resourceType, systemData: systemData, tags: tags, location: location, identity: identity, provisioningState: provisioningState, monitoringStatus: monitoringStatus, marketplaceSubscriptionStatus: marketplaceSubscriptionStatus, marketplaceSubscriptionId: marketplaceSubscriptionId, newRelicAccountProperties: newRelicAccountProperties, userInfo: userInfo, planData: planData, liftrResourceCategory: liftrResourceCategory, liftrResourcePreference: liftrResourcePreference, orgCreationSource: orgCreationSource, accountCreationSource: accountCreationSource, subscriptionState: default, saaSAzureSubscriptionStatus: default);

return NewRelicMonitorResourceData(

id: id,

name: name,

resourceType: resourceType,

systemData: systemData,

tags: tags,

location: location,

identity: identity,

provisioningState: provisioningState,

monitoringStatus: monitoringStatus,

marketplaceSubscriptionStatus: marketplaceSubscriptionStatus,

marketplaceSubscriptionId: marketplaceSubscriptionId,

newRelicAccountProperties: newRelicAccountProperties,

userInfo: userInfo,

planData: planData,

liftrResourceCategory: liftrResourceCategory,

liftrResourcePreference: liftrResourcePreference,

orgCreationSource: orgCreationSource,

accountCreationSource: accountCreationSource,

subscriptionState: default,

saaSAzureSubscriptionStatus: default

);

github-actions · 2025-12-19T05:07:45Z

Hi @mzhongl524. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions · 2025-12-26T08:39:30Z

Hi @mzhongl524. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

Generate SDK code from Swagger

bfa73f6

mzhongl524 added the Mgmt This issue is related to a management package. label Oct 15, 2025

mzhongl524 added 4 commits October 15, 2025 17:48

Merge branch 'main' into pr-newrelic

16f8459

updated

b3a275f

updated

1c4ff06

fixed changelog

2e981ed

mzhongl524 marked this pull request as ready for review October 16, 2025 03:27

mzhongl524 requested a review from vipray-ms as a code owner October 16, 2025 03:27

Copilot AI review requested due to automatic review settings October 16, 2025 03:27

Copilot AI reviewed Oct 16, 2025

View reviewed changes

ArcturusZhang reviewed Oct 17, 2025

View reviewed changes

Comment thread sdk/newrelicobservability/Azure.ResourceManager.NewRelicObservability/src/autorest.md Outdated

ArcturusZhang reviewed Oct 17, 2025

View reviewed changes

Comment thread sdk/newrelicobservability/Azure.ResourceManager.NewRelicObservability/src/autorest.md Outdated

mzhongl524 added 2 commits October 17, 2025 14:10

Merge remote-tracking branch 'upstream/main' into pr-newrelic

780f924

remove directive and add custom code

9ae36c0

ArcturusZhang approved these changes Oct 17, 2025

View reviewed changes

ArcturusZhang added the Do Not Merge label Oct 17, 2025

github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Dec 19, 2025

github-actions Bot closed this Dec 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NewRelic] SDK validation for TypeSpec swagger#53254

[NewRelic] SDK validation for TypeSpec swagger#53254
mzhongl524 wants to merge 7 commits intoAzure:mainfrom
mzhongl524:pr-newrelic

mzhongl524 commented Oct 15, 2025

Uh oh!

github-actions Bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mzhongl524 commented Oct 15, 2025

Contributing to the Azure SDK

Uh oh!

github-actions Bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 16, 2025 •

edited

Loading